Chromium Code Reviews| Index: chrome/test/data/webui/settings/settings_page_browsertest.js |
| diff --git a/chrome/test/data/webui/settings/settings_page_browsertest.js b/chrome/test/data/webui/settings/settings_page_browsertest.js |
| index 2b8e53d2afbd2ca0e7258940699d20d58446fe5a..4948ebd2aa1896d6aa9b948bd9f549016187da9d 100644 |
| --- a/chrome/test/data/webui/settings/settings_page_browsertest.js |
| +++ b/chrome/test/data/webui/settings/settings_page_browsertest.js |
| @@ -31,14 +31,14 @@ SettingsPageBrowserTest.prototype = { |
| /** |
| * @param {string} type The settings page type, e.g. 'advanced' or 'basic'. |
| - * @return {Node} The DOM node for the page. |
| + * @return {!PolymerElement} The PolymerElement for the page. |
|
michaelpg
2015/11/24 15:55:49
Cool, I didn't even know this extern existed.
stevenjb
2015/11/24 17:04:50
Acknowledged.
|
| */ |
| getPage: function(type) { |
| var settings = document.querySelector('cr-settings'); |
| assertTrue(!!settings); |
| - var settingsUi = settings.shadowRoot.querySelector('settings-ui'); |
| + var settingsUi = settings.$$('settings-ui'); |
| assertTrue(!!settingsUi); |
| - var settingsMain = settingsUi.shadowRoot.querySelector('settings-main'); |
| + var settingsMain = settingsUi.$$('settings-main'); |
| assertTrue(!!settingsMain); |
| var pages = settingsMain.$.pageContainer; |
| assertTrue(!!pages); |
| @@ -49,9 +49,9 @@ SettingsPageBrowserTest.prototype = { |
| }, |
| /** |
| - * @param {Node} page The DOM node for the settings page containing |section|. |
| + * @param {!Node} page The DOM node for the page containing |section|. |
|
michaelpg
2015/11/24 15:55:49
!PolymerElement
stevenjb
2015/11/24 17:04:50
Done.
|
| * @param {string} section The settings page section, e.g. 'appearance'. |
| - * @return {Node} The DOM node for the section. |
| + * @return {!SettingsSection} The DOM node for the section. |
| */ |
| getSection: function(page, section) { |
| var sections = page.shadowRoot.querySelectorAll('settings-section'); |