Add Settings bluetooth page test

chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js

Index: chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js
diff --git a/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js b/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js
new file mode 100644
index 0000000000000000000000000000000000000000..cc01d7f5c121978a47e8107c78361446e3ad37a8
--- /dev/null
+++ b/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js
@@ -0,0 +1,148 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/** @fileoverview Suite of tests for settings-bluetooth-page. */
+
+GEN_INCLUDE(['settings_page_browsertest.js']);
+
+var bluetoothPage = bluetoothPage || {};
+
+/**
+ * @constructor
+ * @extends {SettingsPageBrowserTest}
+*/
+function SettingsBluetoothPageBrowserTest() {
+}
+
+SettingsBluetoothPageBrowserTest.prototype = {
+  __proto__: SettingsPageBrowserTest.prototype,
+
+  /** @override */
+  browsePreload: 'chrome://md-settings/advanced',
+
+  /** @override */
+  extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
+    '../fake_chrome_event.js',
+    'fake_bluetooth.js',
+    'fake_bluetooth_private.js'
+  ]),
+
+  /** @type {Bluetooth} */
+  bluetoothApi_: undefined,
+
+  /** @type {BluetoothPrivate} */
+  bluetoothPrivateApi_: undefined,
+
+  /** @override */
+  preLoad: function() {
+    SettingsPageBrowserTest.prototype.preLoad.call(this);
+    settingsHidePagesByDefaultForTest = true;
+    this.bluetoothApi_ = new settings.FakeBluetooth();
+    this.bluetoothPrivateApi_ =
+        new settings.FakeBluetoothPrivate(this.bluetoothApi_);
+    // Set globals to override Settings Bluetooth Page apis.
+    bluetoothPage.bluetoothApiForTest = this.bluetoothApi_;
+    bluetoothPage.bluetoothPrivateApiForTest = this.bluetoothPrivateApi_;
+  }
+};
+
+// Times out on debug builders and may time out on memory bots because
+// the Settings page can take several seconds to load in a Release build
+// and several times that in a Debug build. See https://crbug.com/558434.
+GEN('#if defined(MEMORY_SANITIZER) || !defined(NDEBUG)');
+GEN('#define MAYBE_Bluetooth DISABLED_Bluetooth');
+GEN('#else');
+GEN('#define MAYBE_Bluetooth Bluetooth');
+GEN('#endif');
+
+// Runs bluetooth tests.
+TEST_F('SettingsBluetoothPageBrowserTest', 'MAYBE_Bluetooth', function() {
+  // Differentiate |this| in the Test from |this| in suite() and test(), see
+  // comment at the top of mocha_adapter.js.
+  var self = this;
+
+  var advanced = self.getPage('advanced');
+  assertTrue(!!advanced);
+  advanced.set('pageVisibility.bluetooth', true);
+  Polymer.dom.flush();
+
+  /** @type {!Array<!chrome.bluetooth.Device>} */ var fakeDevices_ = [
+    {
+      address: '10:00:00:00:00:01',
+      name: 'FakePairedDevice1',
+      paired: true,
+    },
+    {
+      address: '10:00:00:00:00:02',
+      name: 'FakePairedDevice2',
+      paired: true,
+    },
+    {
+      address: '00:00:00:00:00:01',
+      name: 'FakeUnPairedDevice1',
+      paired: false,
+    },
+  ];
+
+  suite('SettingsBluetoothPage', function() {
+    test('enable', function() {
+      assertFalse(self.bluetoothApi_.enabled);

[Dan Beam, 2015/12/28 20:01:39]

yeah, this just a case of |this| changing when introducing a new scope

[michaelpg, 2015/12/28 20:39:36]

these functions are .call()d with a particular context object. i think it's
either:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/mocha/...

or

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/mocha/...

[stevenjb, 2015/12/28 20:49:16]

Acknowledged.

+      var bluetoothSection = self.getSection(advanced, 'bluetooth');
+      assertTrue(!!bluetoothSection);
+      var bluetooth =
+          bluetoothSection.querySelector('settings-bluetooth-page');
+      assertTrue(!!bluetooth);
+      expectFalse(bluetooth.bluetoothEnabled);
+      var enable = bluetooth.$.enableBluetooth;
+      assertTrue(!!enable);
+      expectFalse(enable.checked);
+      // Test that tapping the enable checkbox changes its value and calls
+      // bluetooth.setAdapterState with powered = false.
+      MockInteractions.tap(enable);
+      expectTrue(enable.checked);
+      expectTrue(self.bluetoothApi_.enabled);
+      // Confirm that 'bluetoothEnabled' remains set to true.
+      Polymer.dom.flush();
+      expectTrue(bluetooth.bluetoothEnabled);
+      // Set 'bluetoothEnabled' directly and confirm that the checkbox
+      // toggles.
+      bluetooth.bluetoothEnabled = false;
+      Polymer.dom.flush();
+      expectFalse(enable.checked);
+    });
+
+    test('device list', function() {

[Dan Beam, 2015/12/28 20:01:39]

I think we still might be better off doing the minimal amount per browser_test,
due to timeouts.

This might be accomplished by moving the setup stuff from the top of
SettingsBluetoothPageBrowserTest.BlueTooth to the fixture, i.e.

  SettingsBluetoothPageBrowserTest.prototype = {
    ...
    setUp: function() {
      ... getPage('advanced') ...
      ... set this.* stuff to be used in test cases ...
    },
  };

And then doing TEST_F('test 1', ... suite(), test() ...), TEST_F('test 2',
suite(), test() ...)

I'm still really worried about timeouts (and the fact that you have to add this
test with a MAYBE_ is kind of an indicator we all should be as well).

[stevenjb, 2015/12/28 20:49:16]

Understood, but I am also worried about per-test overhead. The vast majority of
the overhead is the initial page load, I don't think each test() invocation
costs very much, but I can verify that.

[stevenjb, 2015/12/28 20:49:16]

Understood, but I am also worried about per-test overhead. The vast majority of
the overhead is the initial page load, I don't think each test() invocation
costs very much, but I can verify that.

+      var bluetoothSection = self.getSection(advanced, 'bluetooth');
+      var bluetooth =
+          bluetoothSection.querySelector('settings-bluetooth-page');
+      assertTrue(!!bluetooth);
+      var deviceList = bluetooth.$.deviceList;
+      assertTrue(!!deviceList);
+      // Set enabled, with default (empty) device list.
+      self.bluetoothApi_.enabled = true;
+      bluetooth.bluetoothEnabled = true;
+      Polymer.dom.flush();
+      // Ensure that initially the 'device list empty' span is visible.
+      expectFalse(deviceList.hidden);
+      var noDevices = deviceList.querySelector('span');
+      assertTrue(!!noDevices);
+      expectFalse(noDevices.hidden);
+      // Set some devices (triggers onDeviceAdded events). 'empty' span should
+      // be hidden.
+      self.bluetoothApi_.setDevicesForTest(fakeDevices_);
+      Polymer.dom.flush();
+      expectTrue(noDevices.hidden);
+      // Confirm that there are three devices in the list.
+      var devices = deviceList.querySelectorAll('iron-selector div');
+      assertEquals(3, devices.length);
+      // Only paired devices should be visible.
+      expectFalse(devices[0].hidden);
+      expectFalse(devices[1].hidden);
+      expectTrue(devices[2].hidden);
+    });
+  });
+
+  // Run all registered tests.
+  mocha.run();
+});