Add Settings bluetooth page test

chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-bluetooth-page' is the settings page for managing bluetooth
  *  properties and devices.
  *
  * Example:
  *    <core-animated-pages>
  *      <settings-bluetooth-page>
  *      </settings-bluetooth-page>
  *      ... other pages ...
  *    </core-animated-pages>
  *
  * @group Chrome Settings Elements
  * @element settings-bluetooth-page
  */
+
+var bluetoothPage = bluetoothPage || {

[michaelpg, 2015/12/17 22:07:16]

use cr.define?

[stevenjb, 2015/12/17 22:13:57]

Hm, interesting question. I'm a bit reluctant to "pollute" the cr namespace with
test specific objects. I'd be curious to see what Dan has to say, but if you're
pretty certain that would be preferable I can change this now, otherwise we can
re-visit it later.

[Dan Beam, 2015/12/28 21:55:15]

cr.exportPath('bluetoothPage'); seems to do something like this

i wasn't sure if this was just an object or a namespace.  the distinction is
hazy in JS.  I'm fine with either way but define() or exportPath() have mild
benefits as we can change all the behaviors of these at once (from both the
runtime and compiler pass's perspectives).

+  /**
+   * Set this to provide a fake implementation for testing.
+   * @type {Bluetooth}
+   */
+  bluetoothApiForTest: null,
+
+  /**
+   * Set this to provide a fake implementation for testing.
+   * @type {BluetoothPrivate}
+   */
+  bluetoothPrivateApiForTest: null,
+};
+
 Polymer({
   is: 'settings-bluetooth-page',
 
   behaviors: [
     I18nBehavior,
   ],
 
   properties: {
     /** The current active route. */
     currentRoute: {
@@ skipping 10 matching lines @@
      */
     deviceList: {type: Array, value: function() { return []; }},
 
     /** The index of the selected device or -1 if none. */
     selectedDevice: {type: Number, value: -1},
 
     /**
      * Interface for bluetooth calls. May be overriden by tests.
      * @type {Bluetooth}
      */
     bluetooth: {

[michaelpg, 2015/12/17 22:07:17]

does this need to be a Polymer property vs. a vanilla property on the prototype?

[stevenjb, 2015/12/17 22:13:57]

It will likely get passed to subpages, so probably. I could make it vanilla for
now if you would prefer.

       type: Object,
       value: chrome.bluetooth,
     },
 
     /**
      * Interface for bluetoothPrivate calls. May be overriden by tests.
      * @type {BluetoothPrivate}
      */
     bluetoothPrivate: {

[michaelpg, 2015/12/17 22:07:17]

same

       type: Object,
       value: chrome.bluetoothPrivate,
     },
   },
 
   /**
    * Listener for chrome.bluetooth.onAdapterStateChanged events.
    * @type {function(!chrome.bluetooth.AdapterState)|undefined}
    * @private
    */
   bluetoothAdapterStateChangedListener_: undefined,
 
   /**
    * Listener for chrome.bluetooth.onBluetoothDeviceAdded/Changed events.
    * @type {function(!chrome.bluetooth.Device)|undefined}
    * @private
    */
   bluetoothDeviceUpdatedListener_: undefined,
 
   /**
    * Listener for chrome.bluetooth.onBluetoothDeviceRemoved events.
    * @type {function(!chrome.bluetooth.Device)|undefined}
    * @private
    */
   bluetoothDeviceRemovedListener_: undefined,
 
+  /** @override */
+  ready: function() {
+    if (bluetoothPage.bluetoothApiForTest)
+      this.bluetooth = bluetoothPage.bluetoothApiForTest;
+    if (bluetoothPage.bluetoothPrivateApiForTest)
+      this.bluetoothPrivate = bluetoothPage.bluetoothPrivateApiForTest;
+  },
 
   /** @override */
   attached: function() {
     this.bluetoothAdapterStateChangedListener_ =
         this.onBluetoothAdapterStateChanged_.bind(this);
     this.bluetooth.onAdapterStateChanged.addListener(
         this.bluetoothAdapterStateChangedListener_);
 
     this.bluetoothDeviceUpdatedListener_ =
         this.onBluetoothDeviceUpdated_.bind(this);
@@ skipping 128 matching lines @@
   /**
    * @param {!chrome.bluetooth.Device} device
    * @return {boolean} True if |device| should be shown in the device list.
    * @private
    */
   showDeviceInList_: function(device) {
     return !!device.paired || !!device.connected || !!device.connecting;
   },
 
   /**
-   * @param {!Array<!chrome.bluetooth.Device>} deviceList
+   * @param {Object} deviceListChanges
    * @return {boolean} True if deviceList is not empty.
    * @private
    */
-  haveDevices_: function(deviceList) { return !!deviceList.length; },
+  haveDevices_: function(deviceListChanges) {
+    return !!this.deviceList.length;
+  },
 
   /**
    * @param {number} selectedDevice
    * @return {boolean} True if a device is selected.
    * @private
    */
   haveSelectedDevice_: function(selectedDevice) { return selectedDevice >= 0; },
 
   /** @private */
   onConnectTap_: function() {
@@ skipping 36 matching lines @@
               'Error forgetting devce: ' + device.name + ': ' +
                   chrome.runtime.lastError.message);
         }
       });
     }
   },
 
   /** @private */
   onAddDeviceTap_: function() {}
 });