Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1466423005: Add browser_tests, content_browsertests and extensions_browsertests to WebKit Linux Oilpan (Closed)

Created:
5 years ago by haraken
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add browser_tests, content_browsertests and extensions_browsertests to WebKit Linux Oilpan BUG= Committed: https://crrev.com/fb826053226d130b60c70a49a52cc03c17d3ada7 Cr-Commit-Position: refs/heads/master@{#361325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M testing/buildbot/chromium.webkit.json View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
haraken
PTAL
5 years ago (2015-11-24 10:32:25 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years ago (2015-11-24 10:34:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466423005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466423005/1
5 years ago (2015-11-24 10:36:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 12:20:46 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fb826053226d130b60c70a49a52cc03c17d3ada7 Cr-Commit-Position: refs/heads/master@{#361325}
5 years ago (2015-11-24 12:21:38 UTC) #8
sof
Enabling this is exposing various untidy shutdowns in unit tests, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/builds/31338
5 years ago (2015-11-24 14:43:44 UTC) #10
haraken
On 2015/11/24 14:43:44, sof wrote: > Enabling this is exposing various untidy shutdowns in unit ...
5 years ago (2015-11-24 14:50:35 UTC) #11
sof
5 years ago (2015-11-24 14:55:42 UTC) #12
Message was sent while issue was closed.
On 2015/11/24 14:50:35, haraken wrote:
> On 2015/11/24 14:43:44, sof wrote:
> > Enabling this is exposing various untidy shutdowns in unit tests,
> > 
> >  
> >
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/...
> 
> Yeah, this seems too many... Would it be better to revert the CL and work on
> them locally?

I don't mind just keeping them around if addressing them won't take too long.
But, I'm assuming these are blockers to getting any official builds ready.

Powered by Google App Engine
This is Rietveld 408576698