Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1466423003: Remove content_common from delegate_execute (Closed)

Created:
5 years, 1 month ago by brettw
Modified:
5 years ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove content_common from delegate_execute This is not used and entirely dead-code-stripped by the linker (sadly this change doesn't make the binary any smaller). Committed: https://crrev.com/9f16faf17eb4250aaf392ee83316d6c7bad9a916 Cr-Commit-Position: refs/heads/master@{#361398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M win8/delegate_execute/delegate_execute.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
Discovered doing GN conversion...
5 years, 1 month ago (2015-11-23 20:20:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466423003/1
5 years, 1 month ago (2015-11-23 20:22:04 UTC) #4
scottmg
lgtm
5 years ago (2015-11-23 20:45:22 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-23 21:06:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466423003/1
5 years ago (2015-11-24 18:33:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 18:42:07 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 18:42:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f16faf17eb4250aaf392ee83316d6c7bad9a916
Cr-Commit-Position: refs/heads/master@{#361398}

Powered by Google App Engine
This is Rietveld 408576698