base/prefs/default_pref_store_unittest.cc - Issue 1466413002: Update gtest to 786564fa4a3c, switch to googlemock in gtest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/prefs/default_pref_store_unittest.cc

Issue 1466413002: Update gtest to 786564fa4a3c, switch to googlemock in gtest Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/power_monitor/power_monitor_unittest.cc ('k') | base/prefs/json_pref_store_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/prefs/default_pref_store.h"	5 #include "base/prefs/default_pref_store.h"

6 #include "testing/gtest/include/gtest/gtest.h"	6 #include "testing/gtest/googletest/include/gtest/gtest.h"

7	7

8 using base::StringValue;	8 using base::StringValue;

9 using base::Value;	9 using base::Value;

10	10

11 namespace {	11 namespace {

12	12

13 class MockPrefStoreObserver : public PrefStore::Observer {	13 class MockPrefStoreObserver : public PrefStore::Observer {

14 public:	14 public:

15 explicit MockPrefStoreObserver(DefaultPrefStore* pref_store);	15 explicit MockPrefStoreObserver(DefaultPrefStore* pref_store);

16 ~MockPrefStoreObserver() override;	16 ~MockPrefStoreObserver() override;

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
60 pref_store->ReplaceDefaultValue(kPrefKey,	60 pref_store->ReplaceDefaultValue(kPrefKey,

61 scoped_ptr<Value>(new StringValue("bar")));	61 scoped_ptr<Value>(new StringValue("bar")));

62 EXPECT_EQ(1, observer.change_count());	62 EXPECT_EQ(1, observer.change_count());

63	63

64 // But only if the value actually changed.	64 // But only if the value actually changed.

65 pref_store->ReplaceDefaultValue(kPrefKey,	65 pref_store->ReplaceDefaultValue(kPrefKey,

66 scoped_ptr<Value>(new StringValue("bar")));	66 scoped_ptr<Value>(new StringValue("bar")));

67 EXPECT_EQ(1, observer.change_count());	67 EXPECT_EQ(1, observer.change_count());

68 }	68 }

69	69

OLD	NEW