Support tooltip for HoverHighlightView

ash/system/tray/hover_highlight_view.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SYSTEM_TRAY_HOVER_HIGHLIGHT_VIEW_H_
 #define ASH_SYSTEM_TRAY_HOVER_HIGHLIGHT_VIEW_H_
 
 #include "ash/system/tray/actionable_view.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
@@ skipping 48 matching lines @@
 
   void set_highlight_color(SkColor color) { highlight_color_ = color; }
   void set_default_color(SkColor color) { default_color_ = color; }
   void set_text_highlight_color(SkColor c) { text_highlight_color_ = c; }
   void set_text_default_color(SkColor color) { text_default_color_ = color; }
 
   views::Label* text_label() { return text_label_; }
 
   bool hover() const { return hover_; }
 
+  bool GetTooltipText(const gfx::Point& p,
+                      base::string16* tooltip) const override;

[stevenjb, 2015/11/23 20:26:24]

Overrides should be in a separate commented section, typically before other
functions.

// views::View
bool GetTooltipText...

[fqj, 2015/11/23 20:39:03]

Done.

+  void SetTooltipText(const base::string16& tooltip);

[stevenjb, 2015/11/23 20:26:24]

New methods should have a comment.

[fqj, 2015/11/23 20:39:03]

Updated to a trivial setters in headers with implementations.
And you said trivial setters don't require one.

+
  protected:
   // Overridden from views::View.
   void GetAccessibleState(ui::AXViewState* state) override;
 
   // Sets the highlighted color on a text label if |hover| is set.
   void SetHoverHighlight(bool hover);
 
  private:
   // Actually adds the icon and label but does not set the layout manager
   void DoAddIconAndLabel(const gfx::ImageSkia& image,
@@ skipping 17 matching lines @@
   ViewClickListener* listener_;
   views::Label* text_label_;
   SkColor highlight_color_;
   SkColor default_color_;
   SkColor text_highlight_color_;
   SkColor text_default_color_;
   bool hover_;
   bool expandable_;
   bool checkable_;
   bool checked_;
+  base::string16 tooltip_;
 
   DISALLOW_COPY_AND_ASSIGN(HoverHighlightView);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SYSTEM_TRAY_HOVER_HIGHLIGHT_VIEW_H_