Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 1466343002: Upstream //ios/ios.gyp. (Closed)

Created:
5 years ago by sdefresne
Modified:
5 years ago
Reviewers:
droger
CC:
chromium-reviews, Elly Fong-Jones
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream //ios/ios.gyp. BUG=None Committed: https://crrev.com/bc354d2a3e9e34d7d50583ee7012bc8a268d82ab Cr-Commit-Position: refs/heads/master@{#361113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ios/ios.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look. ellyjones: FYI
5 years ago (2015-11-23 15:18:09 UTC) #2
droger
lgtm
5 years ago (2015-11-23 15:18:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466343002/1
5 years ago (2015-11-23 15:19:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-23 16:04:05 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-23 16:05:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc354d2a3e9e34d7d50583ee7012bc8a268d82ab
Cr-Commit-Position: refs/heads/master@{#361113}

Powered by Google App Engine
This is Rietveld 408576698