Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1466323002: Some missed three Isolate::Current calls... delete them anyway (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Some missed three Isolate::Current calls... delete them anyway BUG=2487 R=yangguo@chromium.org LOG=n Committed: https://crrev.com/3b3413442f6fafcabeb527f5d0d2985d3474197e Cr-Commit-Position: refs/heads/master@{#32178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/cctest/test-macro-assembler-mips64.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 1 month ago (2015-11-23 13:31:18 UTC) #1
Yang
On 2015/11/23 13:31:18, jochen wrote:
5 years, 1 month ago (2015-11-23 13:32:11 UTC) #2
Yang
On 2015/11/23 13:32:11, Yang wrote: > On 2015/11/23 13:31:18, jochen wrote: lgtm.
5 years, 1 month ago (2015-11-23 13:32:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466323002/1
5 years, 1 month ago (2015-11-23 13:32:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 13:48:08 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 13:48:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b3413442f6fafcabeb527f5d0d2985d3474197e
Cr-Commit-Position: refs/heads/master@{#32178}

Powered by Google App Engine
This is Rietveld 408576698