Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1466313005: Revert "Add StaleWhileRevalidateExperiment histograms." (Closed)

Created:
5 years ago by raymes
Modified:
5 years ago
Reviewers:
Adam Rice
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add StaleWhileRevalidateExperiment histograms." This reverts commit 51d6bcfd10cb847da284a7aa1202f92ea37b74ca. It looks like it might have introduced a new static initializer, though I can't tell where. See https://build.chromium.org/p/chromium/builders/Linux/builds/68841/steps/sizes/logs/stdio (there is a new SI detected in stale_while_revalidate_experiment_domains.cc _GLOBAL__sub_I_stale_while_revalidate_experiment_domains.cc+0xb) BUG=348877 TBR=ricea@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d7c2a3547acc7ae725795cdee2ec01f09f651b93 Cr-Commit-Position: refs/heads/master@{#361592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -441 lines) Patch
D chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/BUILD.gn View 2 chunks +0 lines, -29 lines 0 comments Download
D net/base/stale_while_revalidate_experiment_domains.h View 1 chunk +0 lines, -25 lines 0 comments Download
D net/base/stale_while_revalidate_experiment_domains.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D net/base/stale_while_revalidate_experiment_domains.gperf View 1 chunk +0 lines, -117 lines 0 comments Download
D net/base/stale_while_revalidate_experiment_domains_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M net/net.gyp View 3 chunks +0 lines, -19 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466313005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466313005/1
5 years ago (2015-11-25 06:29:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 06:30:43 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d7c2a3547acc7ae725795cdee2ec01f09f651b93 Cr-Commit-Position: refs/heads/master@{#361592}
5 years ago (2015-11-25 06:31:57 UTC) #4
Adam Rice
5 years ago (2015-11-25 09:24:54 UTC) #5
Message was sent while issue was closed.
On 2015/11/25 06:31:57, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/d7c2a3547acc7ae725795cdee2ec01f09f651b93
> Cr-Commit-Position: refs/heads/master@{#361592}

Filed bug: http://crbug.com/561283

Powered by Google App Engine
This is Rietveld 408576698