Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1466303005: [test-runner] Make test suite loading more robust. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test-runner] Make test suite loading more robust. BUG= Committed: https://crrev.com/05dda9e27e5cb92af2b4e495ec0a15bd13f9add0 Cr-Commit-Position: refs/heads/master@{#32267}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testrunner/local/testsuite.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 11 (4 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1466303005/diff/1/tools/testrunner/local/testsuite.py File tools/testrunner/local/testsuite.py (left): https://codereview.chromium.org/1466303005/diff/1/tools/testrunner/local/testsuite.py#oldcode98 tools/testrunner/local/testsuite.py:98: except: This caught other errors, but import errors ...
5 years ago (2015-11-25 10:06:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466303005/1
5 years ago (2015-11-25 10:07:04 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-25 11:04:37 UTC) #6
Jakob Kummerow
lgtm
5 years ago (2015-11-25 11:50:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466303005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466303005/1
5 years ago (2015-11-25 12:19:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 12:20:42 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-25 12:21:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05dda9e27e5cb92af2b4e495ec0a15bd13f9add0
Cr-Commit-Position: refs/heads/master@{#32267}

Powered by Google App Engine
This is Rietveld 408576698