Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1466293002: Fix regression in memory-infra bots due to change in dump order (Closed)

Created:
5 years, 1 month ago by ssid
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org, bashi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix regression in memory-infra bots due to change in dump order crrev.com/1427963002 introduced a new memory-infra thread which runs after all dump providers are finished. This measures the process total memory usages. This was previously running at the start of a memory dump. This means that the memory used while taking memory dump of other providers will be included in the totals now and this metric has regressed. This CL is a temporary change that reverts this behaviour so that the perf bots are happy. Better fix for the problem will follow up soon. BUG=555584 Committed: https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8 Cr-Commit-Position: refs/heads/master@{#361126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
ssid
+dsinclair PTAL at this change. This is temporary fix for the regression since primiano is ...
5 years, 1 month ago (2015-11-23 12:22:23 UTC) #2
Primiano Tucci (use gerrit)
LGTM if this is really needed. +CC TOK, I guess this will influence their benchmark ...
5 years, 1 month ago (2015-11-23 15:25:39 UTC) #3
ssid
On 2015/11/23 15:25:39, Primiano Tucci wrote: > LGTM if this is really needed. > +CC ...
5 years, 1 month ago (2015-11-23 16:27:17 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466293002/1
5 years, 1 month ago (2015-11-23 16:28:07 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-23 17:04:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1466293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1466293002/1
5 years, 1 month ago (2015-11-23 17:07:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 17:14:00 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ef89c2a502dadf4458000278ef4befbd79523bf8 Cr-Commit-Position: refs/heads/master@{#361126}
5 years, 1 month ago (2015-11-23 17:15:03 UTC) #12
haraken
LGTM
5 years, 1 month ago (2015-11-24 01:00:15 UTC) #13
ssid
5 years ago (2015-11-26 13:45:41 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1479003003/ by ssid@chromium.org.

The reason for reverting is: Along with this CL, the memory-infra build was
broken (fixed in https://codereview.chromium.org/1474543003/). But, this cause
much noise in the metrics and did not give a clear idea if the change fixed the
original regression. So, I will revert this again and re-land it to check if
that actually makes a difference..

Powered by Google App Engine
This is Rietveld 408576698