[proxies] Refactor JSReceiver::GetKeys()

[proxies] Refactor JSReceiver::GetKeys()

In preparation for implementing proper Proxy support.

Committed: https://crrev.com/27d1c008ee346526fe4a793459ce44ffb8a2e43d
Cr-Commit-Position: refs/heads/master@{#32345}

[Jakob Kummerow, 2015-11-25 11:33:47]

jkummerow@chromium.org changed reviewers:
+ verwaest@chromium.org

[Jakob Kummerow, 2015-11-25 11:33:47]

PTAL. This is just shuffling existing code around in preparation for my next CL.
No change in behavior intended, with one exception (see comment below).

https://codereview.chromium.org/1466243002/diff/20001/src/objects.cc
File src/objects.cc (left):

https://codereview.chromium.org/1466243002/diff/20001/src/objects.cc#oldcode8011
src/objects.cc:8011: if (iter.IsAtEnd(PrototypeIterator::END_AT_NON_HIDDEN)) {
I've dropped this condition as discussed, because per the "hixie spec"
enumeration should silently return only whitelisted properties on access check
failure (see new TODO comment), and shouldn't throw.

https://codereview.chromium.org/1466243002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1466243002/diff/20001/src/objects.cc#newcode8055
src/objects.cc:8055: static bool GetKeysFromJSReceiver(Isolate* isolate,
Handle<JSReceiver> receiver,
We'll need this entry point so that the new GetKeysFromJSProxy() can implement
"Return target.[[OwnPropertyKeys]]()". In other words, this function will
(indirectly) call itself recursively.

[Toon Verwaest, 2015-11-26 14:21:36]

lgtm

[Jakob Kummerow, 2015-11-26 14:25:37]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2015-11-26 14:25:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1466243002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1466243002/60001

[commit-bot: I haz the power, 2015-11-26 14:52:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-26 14:53:20]

Description was changed from

==========
[proxies] Refactor JSReceiver::GetKeys()

In preparation for implementing proper Proxy support.
==========

to

==========
[proxies] Refactor JSReceiver::GetKeys()

In preparation for implementing proper Proxy support.

Committed: https://crrev.com/27d1c008ee346526fe4a793459ce44ffb8a2e43d
Cr-Commit-Position: refs/heads/master@{#32345}
==========

[commit-bot: I haz the power, 2015-11-26 14:53:21]

Patchset 4 (id:??) landed as
https://crrev.com/27d1c008ee346526fe4a793459ce44ffb8a2e43d
Cr-Commit-Position: refs/heads/master@{#32345}