Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/release/test_scripts.py

Issue 1466233002: [release] Remove unused sheriff feature from auto-roller. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/release/common_includes.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/release/test_scripts.py
diff --git a/tools/release/test_scripts.py b/tools/release/test_scripts.py
index 9dafe2d9cd438015c9fbc5a1cecfd6a3c287cd50..eb02719a5c53d38567ada88f15eacfd0d99f1ac5 100644
--- a/tools/release/test_scripts.py
+++ b/tools/release/test_scripts.py
@@ -1015,7 +1015,7 @@ Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
-TBR=g_name@chromium.org,reviewer@chromium.org"""
+TBR=reviewer@chromium.org"""
def testChromiumRoll(self):
# Setup fake directory structures.
@@ -1038,8 +1038,6 @@ TBR=g_name@chromium.org,reviewer@chromium.org"""
"Version 3.22.4 (based on abc)\n"),
Cmd("git describe --tags roll_hsh", "3.22.4"),
Cmd("git describe --tags last_roll_hsh", "3.22.2.1"),
- URL("https://chromium-build.appspot.com/p/chromium/sheriff_v8.js",
- "document.write('g_name')"),
Cmd("git status -s -uno", "", cwd=chrome_dir),
Cmd("git checkout -f master", "", cwd=chrome_dir),
Cmd("git branch", "", cwd=chrome_dir),
@@ -1060,7 +1058,6 @@ TBR=g_name@chromium.org,reviewer@chromium.org"""
self.Expect(expectations)
args = ["-a", "author@chromium.org", "-c", chrome_dir,
- "--sheriff",
"-r", "reviewer@chromium.org",
"--last-roll", "last_roll_hsh",
"roll_hsh"]
« no previous file with comments | « tools/release/common_includes.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698