Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 146623006: Reland of r19102: Check elimination improvement: propagation of state through phis is supported, Che (Closed)

Created:
6 years, 10 months ago by Igor Sheludko
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Reland of r19102: Check elimination improvement: propagation of state through phis is supported, CheckMap narrowing implemented with tests. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19229

Patch Set 1 : Revert of r19179: "[Sheriff] Revert "Check elimination ..." #

Patch Set 2 : The fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -192 lines) Patch
M src/hydrogen-check-elimination.cc View 1 6 chunks +69 lines, -12 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 chunks +10 lines, -2 lines 0 comments Download
A + test/mjsunit/compiler/compare-map-elim.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/compiler/compare-map-elim2.js View 1 1 chunk +88 lines, -43 lines 0 comments Download
D test/mjsunit/compiler/compare_map_elim.js View 1 1 chunk +0 lines, -51 lines 0 comments Download
D test/mjsunit/compiler/compare_objeq_elim.js View 1 1 chunk +0 lines, -85 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 10 months ago (2014-02-10 13:03:53 UTC) #1
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-10 14:55:25 UTC) #2
Igor Sheludko
6 years, 10 months ago (2014-02-10 15:33:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698