Chromium Code Reviews| Index: remoting/remoting.gyp |
| diff --git a/remoting/remoting.gyp b/remoting/remoting.gyp |
| index 713ee4c3e00314f5a6c558d3600fb0e117d522cf..20b7eec8162ba6f1d0fb06cb7619d81dd487eb7d 100644 |
| --- a/remoting/remoting.gyp |
| +++ b/remoting/remoting.gyp |
| @@ -59,16 +59,17 @@ |
| ['OS=="win"', { |
| 'host_plugin_extension': 'dll', |
| 'host_plugin_prefix': '', |
| - # Use auto-generated CLSIDs to make sure that the newly installed COM |
| + |
| + # Each CLSID is a hash of the corresponding interface ID and the |
| + # current version string to make sure that the newly installed COM |
|
Jamie
2014/02/05 18:53:58
How will this impact dev builds on a machine? I've
Sergey Ulanov
2014/02/05 19:47:16
I think potentially the IDs can be generated rando
|
| # classes will be used during/after upgrade even if there are old |
| # instances running already. |
| - # The parameter at the end is ignored, but needed to make sure that the |
| - # script will be invoked separately for each CLSID. Otherwise GYP will |
| - # reuse the value returned by the first invocation of the script. |
| + # The IDs are not random to avoid rebuilding host when it's not |
| + # necessary. |
| 'daemon_controller_clsid': |
| - '<!(python -c "import uuid; print uuid.uuid4()" 1)', |
| + '<!(python -c "import uuid; print uuid.uuid5(uuid.UUID(\'655bd819-c08c-4b04-80c2-f160739ff6ef\'), \'<(version_full)\')")', |
| 'rdp_desktop_session_clsid': |
| - '<!(python -c "import uuid; print uuid.uuid4()" 2)', |
| + '<!(python -c "import uuid; print uuid.uuid5(uuid.UUID(\'6a7699f0-ee43-43e7-aa30-a6738f9bd470\'), \'<(version_full)\')")', |
|
Jamie
2014/02/05 18:53:58
I was originally concerned about duplicating these
Sergey Ulanov
2014/02/05 19:47:16
Correct. I've updated the comments to make it clea
|
| }], |
| ], |
| 'remoting_locales': [ |