Issue 146623003: Improve HConstant::ImmortalImmovable() to check for all immortal immovable roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146623003: Improve HConstant::ImmortalImmovable() to check for all immortal immovable roots. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer

Modified:
6 years, 10 months ago

Reviewers:
Hannes Payer (out of office), Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Improve HConstant::ImmortalImmovable() to check for all immortal immovable roots. Move the list to IMMORTAL_IMMOVABLE_ROOT_LIST in heap.h, and automatically include INTERNALIZED_STRING_LIST and STRING_TYPE_LIST. R=hpayer@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18970

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -29 lines)			Patch
M	src/heap.h	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+1 line, -28 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

6 years, 10 months ago (2014-01-31 07:28:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r18970 (presubmit successful).