Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: ui/views/BUILD.gn

Issue 1466173002: Fix the `sizes` regressions in Linux GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@linux_x64_2
Patch Set: add TODOs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/BUILD.gn
diff --git a/ui/views/BUILD.gn b/ui/views/BUILD.gn
index 21015b5cc5713229c1572530381cbfead81a9d26..4664336f9f23d8fcdd8224cf66c49b46de40125b 100644
--- a/ui/views/BUILD.gn
+++ b/ui/views/BUILD.gn
@@ -15,7 +15,10 @@ config("flags") {
defines = [ "TOOLKIT_VIEWS=1" ]
}
-component("views") {
+static_library("views") {
+ # TODO(crbug.com/559766) this should be a component but
+ # there are static initializers that get accidentally linked
+ # into chrome from that need to be addressed first.
all_dependent_configs = [ ":flags" ]
sources = gypi_values.views_sources

Powered by Google App Engine
This is Rietveld 408576698