Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Unified Diff: net/quic/quic_connection.cc

Issue 1466153002: Clear the connection's send alarm when a new ack is received. Flag protected by gfe2_reloadable_fl… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@107691686
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index 79d5131aa5ee8eca2253810e31225aebd3e0ed46..81bc1fb9ea4555c1ddd07da6e30ed5268dc95256 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -737,6 +737,10 @@ bool QuicConnection::OnAckFrame(const QuicAckFrame& incoming_ack) {
return false;
}
+ if (FLAGS_quic_respect_send_alarm &&
+ send_alarm_->IsSet()) {
+ send_alarm_->Cancel();
+ }
ProcessAckFrame(incoming_ack);
if (incoming_ack.is_truncated) {
should_last_packet_instigate_acks_ = true;
@@ -1475,7 +1479,8 @@ bool QuicConnection::CanWrite(HasRetransmittableData retransmittable) {
}
// If the send alarm is set, wait for it to fire.
- if (FLAGS_respect_send_alarm && send_alarm_->IsSet()) {
+ if (FLAGS_quic_respect_send_alarm &&
+ send_alarm_->IsSet()) {
return false;
}
@@ -1494,7 +1499,7 @@ bool QuicConnection::CanWrite(HasRetransmittableData retransmittable) {
<< "ms";
return false;
}
- if (!FLAGS_respect_send_alarm) {
+ if (!FLAGS_quic_respect_send_alarm) {
send_alarm_->Cancel();
}
return true;
« no previous file with comments | « no previous file | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698