arc-bridge: Enable ARC with a command-line flag

arc-bridge: Enable ARC with a command-line flag

We have permission to remove the build time flag in favor of a runtime
flag for enabling ARC Bridge Service, conditional on committing to a
more stable and appropriate IPC mechanism for the bridge.

BUG=559654
TEST=components_unittests

Committed: https://crrev.com/89b91de77ee7fa5ac5103ff1b9355c8230abcca5
Cr-Commit-Position: refs/heads/master@{#361484}

[lhc(google), 2015-11-21 18:05:08]

lhchavez@google.com changed reviewers:
+ elijahtaylor@chromium.org, jochen@chromium.org, oshima@chromium.org

[lhc(google), 2015-11-21 18:05:08]

PTAL

elijahtaylor:
  components/arc/
jochen:
  build/
  chrome/browser/ui/BUILD.gn
  components/BUILD.gn
  components/components.gyp
oshima:
  chrome/browser/chromeos/
  chrome/browser/ui/ash/

[elijahtaylor (use chromium), 2015-11-23 18:01:03]

elijahtaylor@google.com changed reviewers:
+ elijahtaylor@google.com

[elijahtaylor (use chromium), 2015-11-23 18:01:04]

Might want to loop in jorgelo@ because he is the one that ok'd this idea, with
the idea that we'll be transitioning off chrome IPC soon.

https://codereview.chromium.org/1466143002/diff/20001/components/arc/arc_brid...
File components/arc/arc_bridge_service.cc (right):

https://codereview.chromium.org/1466143002/diff/20001/components/arc/arc_brid...
components/arc/arc_bridge_service.cc:245: if (state_ != State::STARTING &&
state_ != State::READY) {
this doesn't seem related to the flag, what is this for?

https://codereview.chromium.org/1466143002/diff/20001/components/arc/arc_brid...
File components/arc/arc_bridge_service_unittest.cc (right):

https://codereview.chromium.org/1466143002/diff/20001/components/arc/arc_brid...
components/arc/arc_bridge_service_unittest.cc:71: void
OnInstanceBootPhase(InstanceBootPhase boot_phase) override {
?

[Luis Héctor Chávez, 2015-11-23 18:02:45]

lhchavez@chromium.org changed reviewers:
+ jorgelo@chromium.org

[Luis Héctor Chávez, 2015-11-23 18:02:46]

+jorgelo

https://codereview.chromium.org/1466143002/diff/20001/components/arc/arc_brid...
File components/arc/arc_bridge_service.cc (right):

https://codereview.chromium.org/1466143002/diff/20001/components/arc/arc_brid...
components/arc/arc_bridge_service.cc:245: if (state_ != State::STARTING &&
state_ != State::READY) {
On 2015/11/23 18:01:04, elijahtaylor (use chromium) wrote:
> this doesn't seem related to the flag, what is this for?

This is a fix for a test breakage that we did not notice since it was not being
tested :(

https://codereview.chromium.org/1466143002/diff/20001/components/arc/arc_brid...
File components/arc/arc_bridge_service_unittest.cc (right):

https://codereview.chromium.org/1466143002/diff/20001/components/arc/arc_brid...
components/arc/arc_bridge_service_unittest.cc:71: void
OnInstanceBootPhase(InstanceBootPhase boot_phase) override {
On 2015/11/23 18:01:04, elijahtaylor (use chromium) wrote:
> ?

Same as the other unrelated fix: build breakage that we did not notice since it
was not being built.

[elijahtaylor (use chromium), 2015-11-23 18:12:12]

lgtm, but I'm not an owner of components, only components/arc, so jochen will
have to stamp that part too

[Jorge Lucangeli Obes, 2015-11-23 18:20:01]

lgtm as long as the flag is not enabled on non-ARC builds of Chrome OS.

[oshima, 2015-11-23 18:27:20]

lgtm

[jochen (gone - plz use gerrit), 2015-11-24 12:43:26]

lgtm

[Luis Héctor Chávez, 2015-11-24 17:05:55]

The CQ bit was checked by lhchavez@chromium.org

[commit-bot: I haz the power, 2015-11-24 17:08:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1466143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1466143002/20001

[commit-bot: I haz the power, 2015-11-24 17:12:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 17:12:28]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Luis Héctor Chávez, 2015-11-24 17:31:26]

The CQ bit was checked by lhchavez@chromium.org

[Luis Héctor Chávez, 2015-11-24 17:31:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
jorgelo@chromium.org, elijahtaylor@google.com, jochen@chromium.org,
oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1466143002/#ps40001
(title: "Rebased to ToT")

[commit-bot: I haz the power, 2015-11-24 17:33:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1466143002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1466143002/40001

[commit-bot: I haz the power, 2015-11-24 20:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 20:13:06]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Luis Héctor Chávez, 2015-11-24 20:16:30]

The CQ bit was checked by lhchavez@chromium.org

[commit-bot: I haz the power, 2015-11-24 20:18:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1466143002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1466143002/40001

[commit-bot: I haz the power, 2015-11-24 23:18:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-24 23:18:50]

Patchset 3 (id:??) landed as
https://crrev.com/89b91de77ee7fa5ac5103ff1b9355c8230abcca5
Cr-Commit-Position: refs/heads/master@{#361484}