third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp - Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: conditionally define GC mixin leftmost bases Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h ('k') | third_party/WebKit/Source/core/html/forms/DateInputType.h » ('j') | third_party/WebKit/Source/core/html/forms/DateInputType.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp b/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

index 60009f440e6eec3d02eab7b0add4c3f2b8dd0b5f..171dddd4dc5fde24b8889dd1521a0f5410538b05 100644

--- a/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

@@ -38,9 +38,26 @@

namespace blink {

+BaseChooserOnlyDateAndTimeInputType::BaseChooserOnlyDateAndTimeInputType(HTMLInputElement& element)

+ : BaseDateAndTimeInputType(element)

+#if ENABLE(OILPAN)

+ ThreadState::current()->registerPreFinalizer(this);

+#endif

BaseChooserOnlyDateAndTimeInputType::~BaseChooserOnlyDateAndTimeInputType()

{

+#if !ENABLE(OILPAN)

closeDateTimeChooser();

+#endif

haraken 2015/11/22 01:01:39 ASSERT(!m_dateTimeChooser).

sof 2015/11/22 08:39:05 Done.

+DEFINE_TRACE(BaseChooserOnlyDateAndTimeInputType)

+ visitor->trace(m_dateTimeChooser);

+ BaseDateAndTimeInputType::trace(visitor);

+ DateTimeChooserClient::trace(visitor);

}

void BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent(Event*)