Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a prefinalizer Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
diff --git a/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h b/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
index ce37c91349de4742ecf73cd2068ecdcf30d6c4c0..5ba190f58c9de681fdbde7f3b55aef6471e0417f 100644
--- a/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
+++ b/third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h
@@ -31,14 +31,18 @@
#include "core/html/forms/BaseDateAndTimeInputType.h"
#include "core/html/forms/DateTimeChooser.h"
#include "core/html/forms/DateTimeChooserClient.h"
+#include "platform/heap/Handle.h"
namespace blink {
class BaseChooserOnlyDateAndTimeInputType : public BaseDateAndTimeInputType, public DateTimeChooserClient {
+ WILL_BE_USING_PRE_FINALIZER(BaseChooserOnlyDateAndTimeInputType, closeDateTimeChooser);
protected:
- BaseChooserOnlyDateAndTimeInputType(HTMLInputElement& element) : BaseDateAndTimeInputType(element) { }
+ BaseChooserOnlyDateAndTimeInputType(HTMLInputElement&);
~BaseChooserOnlyDateAndTimeInputType() override;
+ DECLARE_VIRTUAL_TRACE();
+
private:
void closeDateTimeChooser();
@@ -59,7 +63,7 @@ private:
void didChooseValue(double) override;
void didEndChooser() override;
- RefPtr<DateTimeChooser> m_dateTimeChooser;
+ RefPtrWillBeMember<DateTimeChooser> m_dateTimeChooser;
};
}

Powered by Google App Engine
This is Rietveld 408576698