Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simplify GC mixin story Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/ExternalDateTimeChooser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
diff --git a/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp b/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
index b609d71bea0134cef862b172e19064f899ab4845..bb72787b7a4761e25ab96531dd440cad22536d90 100644
--- a/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
+++ b/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
@@ -63,23 +63,29 @@ private:
delete this;
}
- RefPtr<ExternalDateTimeChooser> m_chooser;
+ RefPtrWillBePersistent<ExternalDateTimeChooser> m_chooser;
};
ExternalDateTimeChooser::~ExternalDateTimeChooser()
{
}
+DEFINE_TRACE(ExternalDateTimeChooser)
+{
+ visitor->trace(m_client);
+ DateTimeChooser::trace(visitor);
+}
+
ExternalDateTimeChooser::ExternalDateTimeChooser(DateTimeChooserClient* client)
: m_client(client)
{
ASSERT(client);
}
-PassRefPtr<ExternalDateTimeChooser> ExternalDateTimeChooser::create(ChromeClientImpl* chromeClient, WebViewClient* webViewClient, DateTimeChooserClient* client, const DateTimeChooserParameters& parameters)
+PassRefPtrWillBeRawPtr<ExternalDateTimeChooser> ExternalDateTimeChooser::create(ChromeClientImpl* chromeClient, WebViewClient* webViewClient, DateTimeChooserClient* client, const DateTimeChooserParameters& parameters)
{
ASSERT(chromeClient);
- RefPtr<ExternalDateTimeChooser> chooser = adoptRef(new ExternalDateTimeChooser(client));
+ RefPtrWillBeRawPtr<ExternalDateTimeChooser> chooser = adoptRefWillBeNoop(new ExternalDateTimeChooser(client));
if (!chooser->openDateTimeChooser(chromeClient, webViewClient, parameters))
chooser.clear();
return chooser.release();
@@ -162,13 +168,13 @@ void ExternalDateTimeChooser::didCancelChooser()
void ExternalDateTimeChooser::endChooser()
{
DateTimeChooserClient* client = m_client;
- m_client = 0;
+ m_client = nullptr;
client->didEndChooser();
}
AXObject* ExternalDateTimeChooser::rootAXObject()
{
- return 0;
+ return nullptr;
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/web/ExternalDateTimeChooser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698