third_party/WebKit/Source/core/html/forms/TimeInputType.h - Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/TimeInputType.h

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify GC mixin story Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/MonthInputType.h ('k') | third_party/WebKit/Source/core/html/forms/WeekInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/TimeInputType.h

diff --git a/third_party/WebKit/Source/core/html/forms/TimeInputType.h b/third_party/WebKit/Source/core/html/forms/TimeInputType.h

index 25192ddb3423b151f743b71bf76565dd4edcc081..85ac11189aff5e4cc72c2cfbbd8cf2f06c8c6ea7 100644

--- a/third_party/WebKit/Source/core/html/forms/TimeInputType.h

+++ b/third_party/WebKit/Source/core/html/forms/TimeInputType.h

@@ -47,7 +47,8 @@ public:

static PassRefPtrWillBeRawPtr<InputType> create(HTMLInputElement&);

private:

- TimeInputType(HTMLInputElement&);

+ explicit TimeInputType(HTMLInputElement&);

void countUsage() override;

const AtomicString& formControlType() const override;

Decimal defaultValueForStepUp() const override;

@@ -56,8 +57,8 @@ private:

bool setMillisecondToDateComponents(double, DateComponents*) const override;

void warnIfValueIsInvalid(const String&) const override;

String localizeValue(const String&) const override;

-#if ENABLE(INPUT_MULTIPLE_FIELDS_UI)

+#if ENABLE(INPUT_MULTIPLE_FIELDS_UI)

// BaseMultipleFieldsDateAndTimeInputType functions

String formatDateTimeFieldsState(const DateTimeFieldsState&) const override;

void setupLayoutParameters(DateTimeEditElement::LayoutParameters&, const DateComponents&) const override;