Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert enable_oilpan=1 default Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 22 matching lines...) Expand all
33 #include "core/frame/FrameHost.h" 33 #include "core/frame/FrameHost.h"
34 #include "core/html/HTMLDivElement.h" 34 #include "core/html/HTMLDivElement.h"
35 #include "core/html/HTMLInputElement.h" 35 #include "core/html/HTMLInputElement.h"
36 #include "core/page/ChromeClient.h" 36 #include "core/page/ChromeClient.h"
37 #include "platform/UserGestureIndicator.h" 37 #include "platform/UserGestureIndicator.h"
38 38
39 namespace blink { 39 namespace blink {
40 40
41 BaseChooserOnlyDateAndTimeInputType::~BaseChooserOnlyDateAndTimeInputType() 41 BaseChooserOnlyDateAndTimeInputType::~BaseChooserOnlyDateAndTimeInputType()
42 { 42 {
43 closeDateTimeChooser(); 43 closeDateTimeChooser();
haraken 2015/11/21 16:46:39 This touches m_dateTimeChooser...
sof 2015/11/21 16:59:44 Thanks, thought I'd checked every destructor here.
44 } 44 }
45 45
46 DEFINE_TRACE(BaseChooserOnlyDateAndTimeInputType)
47 {
48 visitor->trace(m_dateTimeChooser);
49 BaseDateAndTimeInputType::trace(visitor);
50 DateTimeChooserClient::trace(visitor);
51 }
52
46 void BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent(Event*) 53 void BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent(Event*)
47 { 54 {
48 if (element().isDisabledOrReadOnly() || !element().layoutObject() || !UserGe stureIndicator::processingUserGesture() || element().openShadowRoot()) 55 if (element().isDisabledOrReadOnly() || !element().layoutObject() || !UserGe stureIndicator::processingUserGesture() || element().openShadowRoot())
49 return; 56 return;
50 57
51 if (m_dateTimeChooser) 58 if (m_dateTimeChooser)
52 return; 59 return;
53 if (!element().document().isActive()) 60 if (!element().document().isActive())
54 return; 61 return;
55 DateTimeChooserParameters parameters; 62 DateTimeChooserParameters parameters;
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 } 150 }
144 151
145 void BaseChooserOnlyDateAndTimeInputType::accessKeyAction(bool sendMouseEvents) 152 void BaseChooserOnlyDateAndTimeInputType::accessKeyAction(bool sendMouseEvents)
146 { 153 {
147 BaseDateAndTimeInputType::accessKeyAction(sendMouseEvents); 154 BaseDateAndTimeInputType::accessKeyAction(sendMouseEvents);
148 BaseClickableWithKeyInputType::accessKeyAction(element(), sendMouseEvents); 155 BaseClickableWithKeyInputType::accessKeyAction(element(), sendMouseEvents);
149 } 156 }
150 157
151 } 158 }
152 #endif 159 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698