Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: third_party/WebKit/Source/web/DateTimeChooserImpl.cpp

Issue 1466113002: Oilpan: move BaseChooserOnlyDateAndTimeInputType to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simplify GC mixin story Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 return adoptRefWillBeNoop(new DateTimeChooserImpl(chromeClient, client, para meters)); 63 return adoptRefWillBeNoop(new DateTimeChooserImpl(chromeClient, client, para meters));
64 } 64 }
65 65
66 DateTimeChooserImpl::~DateTimeChooserImpl() 66 DateTimeChooserImpl::~DateTimeChooserImpl()
67 { 67 {
68 } 68 }
69 69
70 DEFINE_TRACE(DateTimeChooserImpl) 70 DEFINE_TRACE(DateTimeChooserImpl)
71 { 71 {
72 visitor->trace(m_chromeClient); 72 visitor->trace(m_chromeClient);
73 visitor->trace(m_client);
73 DateTimeChooser::trace(visitor); 74 DateTimeChooser::trace(visitor);
74 } 75 }
75 76
76 void DateTimeChooserImpl::endChooser() 77 void DateTimeChooserImpl::endChooser()
77 { 78 {
78 if (!m_popup) 79 if (!m_popup)
79 return; 80 return;
80 m_chromeClient->closePagePopup(m_popup); 81 m_chromeClient->closePagePopup(m_popup);
81 } 82 }
82 83
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 } 198 }
198 199
199 void DateTimeChooserImpl::closePopup() 200 void DateTimeChooserImpl::closePopup()
200 { 201 {
201 endChooser(); 202 endChooser();
202 } 203 }
203 204
204 void DateTimeChooserImpl::didClosePopup() 205 void DateTimeChooserImpl::didClosePopup()
205 { 206 {
206 ASSERT(m_client); 207 ASSERT(m_client);
207 m_popup = 0; 208 m_popup = nullptr;
208 m_client->didEndChooser(); 209 m_client->didEndChooser();
209 } 210 }
210 211
211 } // namespace blink 212 } // namespace blink
212 213
213 #endif // ENABLE(INPUT_MULTIPLE_FIELDS_UI) 214 #endif // ENABLE(INPUT_MULTIPLE_FIELDS_UI)
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/DateTimeChooserImpl.h ('k') | third_party/WebKit/Source/web/ExternalDateTimeChooser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698