[Chromecast] Add setters to CastSysInfoDummy.

[Chromecast] Add setters to CastSysInfoDummy.

Enables changing values in CastSysInfoDummy for unit testing.

R=halliwell@chromium.org,slan@chromium.org

Committed: https://crrev.com/f4f2c9f991147df31b60ecbef9526c4ed7f0b784
Cr-Commit-Position: refs/heads/master@{#360996}

[derekjchow1, 2015-11-21 01:43:30]

The CQ bit was checked by derekjchow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-21 01:44:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1466003003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1466003003/1

[commit-bot: I haz the power, 2015-11-21 01:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-21 01:44:35]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[slan, 2015-11-21 01:49:02]

https://codereview.chromium.org/1466003003/diff/1/chromecast/base/cast_sys_in...
File chromecast/base/cast_sys_info_dummy.cc (right):

https://codereview.chromium.org/1466003003/diff/1/chromecast/base/cast_sys_in...
chromecast/base/cast_sys_info_dummy.cc:11: system_release_channel_(""),
Why are any of the "" initializations necessary?

[derekjchow1, 2015-11-21 01:51:31]

https://codereview.chromium.org/1466003003/diff/1/chromecast/base/cast_sys_in...
File chromecast/base/cast_sys_info_dummy.cc (right):

https://codereview.chromium.org/1466003003/diff/1/chromecast/base/cast_sys_in...
chromecast/base/cast_sys_info_dummy.cc:11: system_release_channel_(""),
On 2015/11/21 01:49:02, slan wrote:
> Why are any of the "" initializations necessary?

Removed.

[slan, 2015-11-21 02:00:51]

lgtm

[halliwell, 2015-11-21 02:05:32]

On 2015/11/21 02:00:51, slan wrote:
> lgtm

nit: convention is to put a 'ForTest' suffix on all such functions to make
intent clear (and then the comment on the class can be removed).

[derekjchow1, 2015-11-21 03:01:26]

The CQ bit was checked by derekjchow@chromium.org

[derekjchow1, 2015-11-21 03:01:26]

The patchset sent to the CQ was uploaded after l-g-t-m from slan@chromium.org
Link to the patchset: https://codereview.chromium.org/1466003003/#ps40001
(title: "Add ForTesting.")

[commit-bot: I haz the power, 2015-11-21 03:02:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1466003003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1466003003/40001

[commit-bot: I haz the power, 2015-11-21 03:02:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-21 03:02:35]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[derekjchow1, 2015-11-21 03:02:41]

The CQ bit was unchecked by derekjchow@chromium.org

[derekjchow1, 2015-11-21 03:02:53]

On 2015/11/21 02:05:32, halliwell wrote:
> On 2015/11/21 02:00:51, slan wrote:
> > lgtm
> 
> nit: convention is to put a 'ForTest' suffix on all such functions to make
> intent clear (and then the comment on the class can be removed).

Done.

[halliwell, 2015-11-21 03:13:15]

On 2015/11/21 03:02:53, derekjchow1 wrote:
> On 2015/11/21 02:05:32, halliwell wrote:
> > On 2015/11/21 02:00:51, slan wrote:
> > > lgtm
> > 
> > nit: convention is to put a 'ForTest' suffix on all such functions to make
> > intent clear (and then the comment on the class can be removed).
> 
> Done.

lgtm

[halliwell, 2015-11-21 03:13:18]

The CQ bit was checked by halliwell@chromium.org

[commit-bot: I haz the power, 2015-11-21 03:14:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1466003003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1466003003/40001

[commit-bot: I haz the power, 2015-11-21 03:45:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-21 03:46:02]

Patchset 3 (id:??) landed as
https://crrev.com/f4f2c9f991147df31b60ecbef9526c4ed7f0b784
Cr-Commit-Position: refs/heads/master@{#360996}