Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3386)

Unified Diff: chrome/browser/ui/search/instant_page.h

Issue 14660022: Move most visited item state info from InstantController to InstantService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_page.h
diff --git a/chrome/browser/ui/search/instant_page.h b/chrome/browser/ui/search/instant_page.h
index e702b2e532621f0a1b05c3fe037a445360c8f5a1..8f58bbce44417e059ee1da92d2de908ff3db6e87 100644
--- a/chrome/browser/ui/search/instant_page.h
+++ b/chrome/browser/ui/search/instant_page.h
@@ -9,6 +9,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "base/gtest_prod_util.h"
#include "base/string16.h"
#include "chrome/common/instant_types.h"
#include "chrome/common/omnibox_focus_state.h"
@@ -88,12 +89,10 @@ class InstantPage : public content::WebContentsObserver {
bool is_search_type) = 0;
// Called when the SearchBox wants to delete a Most Visited item.
- virtual void DeleteMostVisitedItem(
- InstantRestrictedID most_visited_item_id) = 0;
+ virtual void DeleteMostVisitedItem(const GURL& url) = 0;
// Called when the SearchBox wants to undo a Most Visited deletion.
- virtual void UndoMostVisitedDeletion(
- InstantRestrictedID most_visited_item_id) = 0;
+ virtual void UndoMostVisitedDeletion(const GURL& url) = 0;
// Called when the SearchBox wants to undo all Most Visited deletions.
virtual void UndoAllMostVisitedDeletions() = 0;
@@ -218,6 +217,13 @@ class InstantPage : public content::WebContentsObserver {
virtual bool ShouldProcessNavigateToURL();
private:
+ FRIEND_TEST_ALL_PREFIXES(InstantPageTest,
+ DispatchRequestToDeleteMostVisitedItem);
+ FRIEND_TEST_ALL_PREFIXES(InstantPageTest,
+ DispatchRequestToUndoMostVisitedDeletion);
+ FRIEND_TEST_ALL_PREFIXES(InstantPageTest,
+ DispatchRequestToUndoAllMostVisitedDeletions);
+
// Overridden from content::WebContentsObserver:
virtual void RenderViewCreated(
content::RenderViewHost* render_view_host) OVERRIDE;
@@ -257,8 +263,8 @@ class InstantPage : public content::WebContentsObserver {
content::PageTransition transition,
WindowOpenDisposition disposition,
bool is_search_type);
- void OnDeleteMostVisitedItem(InstantRestrictedID most_visited_item_id);
- void OnUndoMostVisitedDeletion(InstantRestrictedID most_visited_item_id);
+ void OnDeleteMostVisitedItem(const GURL& url);
+ void OnUndoMostVisitedDeletion(const GURL& url);
void OnUndoAllMostVisitedDeletions();
Delegate* const delegate_;

Powered by Google App Engine
This is Rietveld 408576698