Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Side by Side Diff: Source/bindings/v8/V8RecursionScope.cpp

Issue 14660019: Run Mutation Observer and Custom Element callbacks consistently at microtask checkpoint (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/CustomElementConstructorBuilder.cpp ('k') | Source/core/core.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "bindings/v8/V8RecursionScope.h" 32 #include "bindings/v8/V8RecursionScope.h"
33 33
34 #include "core/dom/CustomElementRegistry.h" 34 #include "core/dom/Microtask.h"
35 #include "core/dom/MutationObserver.h"
36 #include "modules/indexeddb/IDBPendingTransactionMonitor.h" 35 #include "modules/indexeddb/IDBPendingTransactionMonitor.h"
37 36
38 namespace WebCore { 37 namespace WebCore {
39 38
40 void V8RecursionScope::didLeaveScriptContext() 39 void V8RecursionScope::didLeaveScriptContext()
41 { 40 {
42 // FIXME: Instrument any work that takes place when script exits to c++ (e.g . Mutation Observers). 41 // FIXME: Instrument any work that takes place when script exits to c++ (e.g . Mutation Observers).
43 42
44 // Indexed DB requires that transactions are created with an internal |activ e| flag 43 // Indexed DB requires that transactions are created with an internal |activ e| flag
45 // set to true, but the flag becomes false when control returns to the event loop. 44 // set to true, but the flag becomes false when control returns to the event loop.
46 IDBPendingTransactionMonitor::deactivateNewTransactions(); 45 IDBPendingTransactionMonitor::deactivateNewTransactions();
47 46
48 if (m_isDocumentContext) { 47 if (m_isDocumentContext)
49 MutationObserver::deliverAllMutations(); 48 Microtask::performCheckpoint();
50 CustomElementRegistry::deliverAllLifecycleCallbacks();
51 }
52 } 49 }
53 50
54 } // namespace WebCore 51 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/CustomElementConstructorBuilder.cpp ('k') | Source/core/core.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698