Chromium Code Reviews
Help | Chromium Project | Sign in
(7)

Issue 14660012: Prevent grokdump from crying about invalid input. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by Michael Starzinger
Modified:
2 years, 3 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Prevent grokdump from crying about invalid input. R=ulan@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14572

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M tools/grokdump.py View 2 chunks +14 lines, -4 lines 0 comments Download
Trybot results:
Project "None" does not have a commit queue.

Messages

Total messages: 3 (0 generated)
Michael Starzinger
2 years, 3 months ago (2013-05-07 13:21:47 UTC) #1
ulan
LGTM
2 years, 3 months ago (2013-05-07 13:22:27 UTC) #2
Michael Starzinger
2 years, 3 months ago (2013-05-07 13:24:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14572 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 020f378