Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3113)

Unified Diff: pkg/analyzer/test/generated/resolver_test.dart

Issue 1465983004: Revert "Clean-up the registration of plugins" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/engine_test.dart ('k') | pkg/analyzer/test/generated/test_support.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/resolver_test.dart
diff --git a/pkg/analyzer/test/generated/resolver_test.dart b/pkg/analyzer/test/generated/resolver_test.dart
index 8bf990cd6279b50fade294ab346adf875169b9cf..7c6becec92feec3e38b318e920735725e0697e53 100644
--- a/pkg/analyzer/test/generated/resolver_test.dart
+++ b/pkg/analyzer/test/generated/resolver_test.dart
@@ -1297,7 +1297,6 @@ class ElementResolverTest extends EngineTestCase {
@override
void setUp() {
- super.setUp();
_listener = new GatheringErrorListener();
_typeProvider = new TestTypeProvider();
_resolver = _createResolver();
@@ -4836,7 +4835,7 @@ class A {
}
@reflectiveTest
-class InheritanceManagerTest {
+class InheritanceManagerTest extends EngineTestCase {
/**
* The type provider used to access the types.
*/
@@ -4857,6 +4856,7 @@ class InheritanceManagerTest {
*/
int _numOfMembersInObject = 0;
+ @override
void setUp() {
_typeProvider = new TestTypeProvider();
_inheritanceManager = _createInheritanceManager();
@@ -6060,7 +6060,7 @@ class InheritanceManagerTest {
}
@reflectiveTest
-class LibraryElementBuilderTest {
+class LibraryElementBuilderTest extends EngineTestCase {
/**
* The analysis context used to analyze sources.
*/
@@ -6079,12 +6079,15 @@ class LibraryElementBuilderTest {
return source;
}
+ @override
void setUp() {
_context = AnalysisContextFactory.contextWithCore();
}
+ @override
void tearDown() {
_context = null;
+ super.tearDown();
}
void test_accessorsAcrossFiles() {
@@ -6582,7 +6585,7 @@ class LibraryScopeTest extends ResolverTestCase {
}
@reflectiveTest
-class LibraryTest {
+class LibraryTest extends EngineTestCase {
/**
* The error listener to which all errors will be reported.
*/
@@ -6598,16 +6601,19 @@ class LibraryTest {
*/
Library _library;
+ @override
void setUp() {
_analysisContext = AnalysisContextFactory.contextWithCore();
_errorListener = new GatheringErrorListener();
_library = _createLibrary("/lib.dart");
}
+ @override
void tearDown() {
_errorListener = null;
_analysisContext = null;
_library = null;
+ super.tearDown();
}
void test_getExplicitlyImportsCore() {
@@ -8415,7 +8421,6 @@ class ResolverTestCase extends EngineTestCase {
@override
void setUp() {
- super.setUp();
reset();
}
@@ -10352,7 +10357,6 @@ class StaticTypeAnalyzerTest extends EngineTestCase {
@override
void setUp() {
- super.setUp();
_listener = new GatheringErrorListener();
_typeProvider = new TestTypeProvider();
_analyzer = _createAnalyzer();
@@ -12623,7 +12627,7 @@ int x = 3;
}
@reflectiveTest
-class SubtypeManagerTest {
+class SubtypeManagerTest extends EngineTestCase {
/**
* The inheritance manager being tested.
*/
@@ -12634,7 +12638,9 @@ class SubtypeManagerTest {
*/
CompilationUnitElementImpl _definingCompilationUnit;
+ @override
void setUp() {
+ super.setUp();
AnalysisContext context = AnalysisContextFactory.contextWithCore();
FileBasedSource source =
new FileBasedSource(FileUtilities2.createFile("/test.dart"));
@@ -14487,7 +14493,7 @@ class TypeProviderImplTest extends EngineTestCase {
}
@reflectiveTest
-class TypeResolverVisitorTest {
+class TypeResolverVisitorTest extends EngineTestCase {
/**
* The error listener to which errors will be reported.
*/
@@ -14529,6 +14535,7 @@ class TypeResolverVisitorTest {
_listener.assertNoErrors();
}
+ @override
void setUp() {
_listener = new GatheringErrorListener();
InternalAnalysisContext context = AnalysisContextFactory.contextWithCore();
« no previous file with comments | « pkg/analyzer/test/generated/engine_test.dart ('k') | pkg/analyzer/test/generated/test_support.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698