Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: pkg/analysis_server/test/analysis_abstract.dart

Issue 1465983004: Revert "Clean-up the registration of plugins" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/server/driver.dart ('k') | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/analysis_abstract.dart
diff --git a/pkg/analysis_server/test/analysis_abstract.dart b/pkg/analysis_server/test/analysis_abstract.dart
index 2406a06224dbf24aa1beefc8ec4a8287ee1e2834..98c854899fc9dcc2b11748cb361616268e44854d 100644
--- a/pkg/analysis_server/test/analysis_abstract.dart
+++ b/pkg/analysis_server/test/analysis_abstract.dart
@@ -96,24 +96,21 @@ class AbstractAnalysisTest {
}
AnalysisServer createAnalysisServer(Index index) {
- //
- // Collect plugins
- //
ServerPlugin serverPlugin = new ServerPlugin();
- List<Plugin> plugins = <Plugin>[];
+ // TODO(pq): this convoluted extension registry dance needs cleanup.
+ List<Plugin> plugins = <Plugin>[
+ serverPlugin,
+ linterPlugin,
+ linterServerPlugin
+ ];
+ // Accessing `taskManager` ensures that AE plugins are registered.
+ AnalysisEngine.instance.taskManager;
plugins.addAll(AnalysisEngine.instance.supportedPlugins);
- plugins.add(serverPlugin);
- plugins.add(linterPlugin);
- plugins.add(linterServerPlugin);
addServerPlugins(plugins);
- //
- // Process plugins
- //
+ // process plugins
ExtensionManager manager = new ExtensionManager();
manager.processPlugins(plugins);
- //
- // Create server
- //
+ // create server
return new AnalysisServer(
serverChannel,
resourceProvider,
« no previous file with comments | « pkg/analysis_server/lib/src/server/driver.dart ('k') | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698