Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1465963002: ash: enable packed_resources in ash_shell_lib_with_content deps list (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
Reviewers:
brettw, sky
CC:
chromium-reviews, kalyank, sadrul, brettw, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: enable packed_resources in ash_shell_lib_with_content deps list Now that we have this target, there is no reason to have it commented out. This patch fixes the TODO(GYP) in there. BUG=None R=sky@chromium.org,brettw@chromium.org Committed: https://crrev.com/1c20f89124e7ee56ae6331d2d3d7dfede26ea22c Cr-Commit-Position: refs/heads/master@{#361021}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
tfarina
Scott, PTAL.
5 years, 1 month ago (2015-11-20 19:33:49 UTC) #1
brettw
lgtm
5 years, 1 month ago (2015-11-20 21:41:57 UTC) #3
sky
LGTM
5 years, 1 month ago (2015-11-20 23:49:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465963002/1
5 years, 1 month ago (2015-11-21 12:44:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/121056)
5 years, 1 month ago (2015-11-21 12:48:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465963002/20001
5 years, 1 month ago (2015-11-21 13:01:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-21 13:42:27 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 13:43:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c20f89124e7ee56ae6331d2d3d7dfede26ea22c
Cr-Commit-Position: refs/heads/master@{#361021}

Powered by Google App Engine
This is Rietveld 408576698