Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4662)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 1465953003: Aura Android: ShowBrowserSignin is not defined for Android, use NOTIMPLEMENTED for now (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
index e06a3567edc3df866d5e7fdddd6cf903e5d53f7f..cdc3df7112b61c0bbc09fdbaa340ea9714077258 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
@@ -286,8 +286,14 @@ void InstalledBubbleContent::LinkClicked(views::Link* source, int event_flags) {
GetWidget()->Close();
if (source == sign_in_link_) {
+#if defined(OS_ANDROID)
+ // TODO(bshe): Figure out what to do on Android platform. See
+ // crbug.com/559340.
+ NOTIMPLEMENTED();
+#else
chrome::ShowBrowserSignin(
browser_, signin_metrics::SOURCE_EXTENSION_INSTALL_BUBBLE);
+#endif
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698