Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1465923004: Accept PWS results without a results key (Closed)

Created:
5 years, 1 month ago by cco3
Modified:
5 years ago
Reviewers:
nyquist, mmocny, conleyo
CC:
chromium-reviews, mattreynolds
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Accept PWS results without a results key The Physical Web Service should not have to send a results key if there are no results (and it currently doesn't). This change does a better job of tolerating such responses. BUG=556988 Committed: https://crrev.com/c9a1c0c7453645ae1e800749e0d44cec4bbf7c25 Cr-Commit-Position: refs/heads/master@{#361393}

Patch Set 1 #

Patch Set 2 : Use optJSONArray #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsClient.java View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
conleyo
+mattreynolds,nyquist
5 years, 1 month ago (2015-11-20 22:58:48 UTC) #2
mmocny
lgtm
5 years, 1 month ago (2015-11-23 16:57:24 UTC) #4
nyquist
lgtm
5 years ago (2015-11-24 09:21:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465923004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465923004/20001
5 years ago (2015-11-24 17:56:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 18:36:06 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-24 18:36:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9a1c0c7453645ae1e800749e0d44cec4bbf7c25
Cr-Commit-Position: refs/heads/master@{#361393}

Powered by Google App Engine
This is Rietveld 408576698