chrome/browser/importer/importer_uma.cc - Issue 1465853002: Implement support for importing favorites from Edge on Windows 10.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/importer_uma.cc

Issue 1465853002: Implement support for importing favorites from Edge on Windows 10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another CLANG warning Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/importer/importer_list.cc ('K') | « chrome/browser/importer/importer_list.cc ('k') | chrome/chrome_common.gypi » ('j') | chrome/common/importer/edge_importer_utils_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/importer/importer_uma.cc

diff --git a/chrome/browser/importer/importer_uma.cc b/chrome/browser/importer/importer_uma.cc

index 839dd6e68d397c4b09ba878b8006fa32cb613baf..1f6ffb0b11890d71a9f15aecd75546f608f6328e 100644

--- a/chrome/browser/importer/importer_uma.cc

+++ b/chrome/browser/importer/importer_uma.cc

@@ -22,6 +22,7 @@ enum ImporterTypeMetrics {

#endif

IMPORTER_METRICS_GOOGLE_TOOLBAR5 = 5, // obsolete

IMPORTER_METRICS_BOOKMARKS_FILE = 6,

+ IMPORTER_METRICS_EDGE = 7,

Ilya Sherman 2015/11/26 02:04:43 nit: Should this be guarded with an "#if defined(O

forshaw 2015/11/30 12:57:58 Acknowledged.

// Insert new values here. Never remove any existing values, as this enum is

// used to bucket a UMA histogram, and removing values breaks that.

@@ -41,6 +42,9 @@ void LogImporterUseToMetrics(const std::string& metric_postfix,

case TYPE_IE:

metrics_type = IMPORTER_METRICS_IE;

break;

+ case TYPE_EDGE:

+ metrics_type = IMPORTER_METRICS_EDGE;

+ break;

#endif

case TYPE_FIREFOX:

metrics_type = IMPORTER_METRICS_FIREFOX3;

« chrome/browser/importer/importer_list.cc ('K') | « chrome/browser/importer/importer_list.cc ('k') | chrome/chrome_common.gypi » ('j') | chrome/common/importer/edge_importer_utils_win.h » ('J')