Implement support for importing favorites from Edge on Windows 10.

chrome/utility/importer/ie_importer_win.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_UTILITY_IMPORTER_IE_IMPORTER_WIN_H_
 #define CHROME_UTILITY_IMPORTER_IE_IMPORTER_WIN_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 58 matching lines @@
 
   // This function will read the files in the Favorites folder, and store
   // the bookmark items in |bookmarks| and favicon information in |favicons|.
   void ParseFavoritesFolder(const FavoritesInfo& info,
                             BookmarkVector* bookmarks,
                             favicon_base::FaviconUsageDataList* favicons);
 
   // Determines which version of IE is in use.
   int CurrentIEVersion() const;
 
+  // Set to true when importing the favorite order in old Edge on Windows 10.

[Ilya Sherman, 2015/11/26 02:04:45]

nit: s/favorite/favorites

[forshaw, 2015/11/30 12:57:59]

Acknowledged.

+  bool edge_import_mode_;

[Ilya Sherman, 2015/11/26 02:04:45]

It's a little semantically weird for the IE importer to support Edge importing. 
Is it actually worthwhile to support importing from old versions of Edge?  How
likely are these to appear in the wild?  (Though since the cost of support is
low, maybe it's worth keeping even for a relatively small benefit.)

[forshaw, 2015/11/30 12:57:59]

Well technically Edge is stripped down IE code so the old favorites model was
based on what was already in IE. Imo it therefore makes sense and also removes
code duplication. It would be nice to not implement it. At least for consumer
versions of Windows 10 that is likely to be using the latest version of Edge but
for Enterprise customers they're on a slower release cycle which means they'll
be using the older version of Edge for some time. 

+
   // IE does not have source path. It's used in unit tests only for providing a
-  // fake source.
+  // fake source and it's used if importing old Edge favorites on Windows 10.
   base::FilePath source_path_;
 
   DISALLOW_COPY_AND_ASSIGN(IEImporter);
 };
 
 #endif  // CHROME_UTILITY_IMPORTER_IE_IMPORTER_WIN_H_