Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1465843003: Split Mandoline-specific components out of mojo:core_services. (Closed)

Created:
5 years, 1 month ago by msw
Modified:
5 years, 1 month ago
CC:
chromium-reviews, rjkroege, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, Elliot Glaysher
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split Mandoline-specific components out of mojo:core_services. Remove mojo:desktop_ui and mojo:omnibox aliases from core_services. Note: mojo:desktop_ui wasn't even resolving to mojo://core_services/. (mojo scheme isn't registered prior to mandoline/app/desktop/main.cc) Upload the additional mojo:omnibox component with Mandoline binaries. (mojo:desktop_ui was already being uploaded for the app+resources) Also, don't build mandoline/ui/phone_ui for Linux desktop builds. BUG=NONE TEST=Mandoline still works as intended. R=ben@chromium.org Committed: https://crrev.com/be3db595d911b648a3c0f59edd1b052b7e335b45 Cr-Commit-Position: refs/heads/master@{#360963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -48 lines) Patch
M mandoline/app/register_local_aliases.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M mandoline/services/core_services/application_delegate_factory.h View 1 chunk +0 lines, -5 lines 0 comments Download
D mandoline/services/core_services/application_delegate_factory_aura.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M mandoline/tools/data/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
M mandoline/ui/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
msw
Hey Ben, please take a look; thanks!
5 years, 1 month ago (2015-11-20 23:37:41 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-11-20 23:43:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465843003/1
5 years, 1 month ago (2015-11-20 23:45:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-21 00:37:28 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 00:38:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be3db595d911b648a3c0f59edd1b052b7e335b45
Cr-Commit-Position: refs/heads/master@{#360963}

Powered by Google App Engine
This is Rietveld 408576698