Issue 146583013: Revert 250482 "Re-reland r245404 ("If the destination directory ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146583013: Revert 250482 "Re-reland r245404 ("If the destination directory ..." (Closed)

Created:
6 years, 10 months ago by Michael Moss

Modified:
6 years, 10 months ago

Reviewers:
borenet

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 250482 "Re-reland r245404 ("If the destination directory ..." > Re-reland r245404 ("If the destination directory doesn't contain the desired repo, delete it") > > BUG= > > Review URL: https://codereview.chromium.org/133073015 TBR=borenet@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250878

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+158 lines, -305 lines)			Patch
M	trunk/tools/depot_tools/gclient.py	View	2 chunks	+0 lines, -38 lines	0 comments	Download
M	trunk/tools/depot_tools/gclient_scm.py	View	11 chunks	+107 lines, -38 lines	0 comments	Download
M	trunk/tools/depot_tools/scm.py	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	trunk/tools/depot_tools/tests/gclient_scm_test.py	View	18 chunks	+42 lines, -80 lines	0 comments	Download
M	trunk/tools/depot_tools/tests/gclient_smoketest.py	View	6 chunks	+6 lines, -131 lines	0 comments	Download
M	trunk/tools/depot_tools/tests/scm_unittest.py	View	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

borenet

On 2014/02/13 01:03:20, Michael Moss wrote: > Committed patchset #1 manually as r250878. Err.. Why?

6 years, 10 months ago (2014-02-13 14:01:45 UTC) #3

Michael Moss

6 years, 10 months ago (2014-02-13 17:19:09 UTC) #4

Message was sent while issue was closed.

On 2014/02/13 14:01:45, borenet wrote:
> On 2014/02/13 01:03:20, Michael Moss wrote:
> > Committed patchset #1 manually as r250878.
> 
> Err.. Why?

I think you found this already, but for posterity:
http://code.google.com/p/chromium/issues/detail?id=343229

Expand Messages | Collapse Messages