win_toolchain: add timeout before nuke, hide taskkill output

win_toolchain: add timeout before nuke, hide taskkill output

It's somewhat annoying to have the script delete your toolchain
directory (at least during testing) and it necessitates downloading
3-4G to restore, so add a short timeout before doing so.

Also, hide the output of taskkill'ing mspdbsrv so that the first message
isn't '''ERROR: The process "..." not found.'''.

R=maruel@chromium.org
BUG=323300
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=251084

[M-A Ruel, 2014-02-13 02:46:45]

https://codereview.chromium.org/146583012/diff/1/win_toolchain/get_toolchain_...
File win_toolchain/get_toolchain_if_necessary.py (right):

https://codereview.chromium.org/146583012/diff/1/win_toolchain/get_toolchain_...
win_toolchain/get_toolchain_if_necessary.py:163: print '  desired_hashes',
desired_hashes
print('  desired hashes: %s' % desired_hashes)

I know it's 4x longer but I prefer.

https://codereview.chromium.org/146583012/diff/1/win_toolchain/get_toolchain_...
win_toolchain/get_toolchain_if_necessary.py:166: if os.path.isdir(target_dir):
if bool(int(os.environ.get('CHROME_HEADLESS', '0'))), skip this. Also move this
in a function.

https://codereview.chromium.org/146583012/diff/1/win_toolchain/get_toolchain_...
win_toolchain/get_toolchain_if_necessary.py:174: with open(os.devnull, 'w') as
nul:
'wb'

You don't want non-binary on Windows...

[scottmg, 2014-02-13 17:54:46]

https://codereview.chromium.org/146583012/diff/1/win_toolchain/get_toolchain_...
File win_toolchain/get_toolchain_if_necessary.py (right):

https://codereview.chromium.org/146583012/diff/1/win_toolchain/get_toolchain_...
win_toolchain/get_toolchain_if_necessary.py:163: print '  desired_hashes',
desired_hashes
On 2014/02/13 02:46:46, M-A Ruel wrote:
> print('  desired hashes: %s' % desired_hashes)
> 
> I know it's 4x longer but I prefer.

Done.

https://codereview.chromium.org/146583012/diff/1/win_toolchain/get_toolchain_...
win_toolchain/get_toolchain_if_necessary.py:166: if os.path.isdir(target_dir):
On 2014/02/13 02:46:46, M-A Ruel wrote:
> if bool(int(os.environ.get('CHROME_HEADLESS', '0'))), skip this. Also move
this
> in a function.

Done.

https://codereview.chromium.org/146583012/diff/1/win_toolchain/get_toolchain_...
win_toolchain/get_toolchain_if_necessary.py:174: with open(os.devnull, 'w') as
nul:
On 2014/02/13 02:46:46, M-A Ruel wrote:
> 'wb'
> 
> You don't want non-binary on Windows...

Done.

[M-A Ruel, 2014-02-13 17:57:13]

lgtm

[scottmg, 2014-02-13 18:17:47]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:17:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/146583012/70001

[commit-bot: I haz the power, 2014-02-13 18:19:40]

Change committed as 251084