Extend App Info dialog to include app shortcut and list of permissions

chrome/browser/ui/views/apps/app_info_dialog_views.h

Index: chrome/browser/ui/views/apps/app_info_dialog_views.h
diff --git a/chrome/browser/ui/views/apps/app_info_dialog_views.h b/chrome/browser/ui/views/apps/app_info_dialog_views.h
index 8187a8729b1491bc68132fbde858d88247e8aab5..eb10ec7da2e7168016bc1ad1e240e51870efcad8 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog_views.h
+++ b/chrome/browser/ui/views/apps/app_info_dialog_views.h
@@ -6,6 +6,8 @@
 #define CHROME_BROWSER_UI_VIEWS_APPS_APP_INFO_DIALOG_VIEWS_H_
 
 #include "base/compiler_specific.h"
+#include "chrome/browser/shell_integration.h"
+#include "ui/views/controls/image_view.h"
 #include "ui/views/window/dialog_delegate.h"
 
 class Profile;
@@ -19,7 +21,8 @@ class Label;
 }
 
 // View the information about a particular chrome application.
-class AppInfoView : public views::DialogDelegateView {
+class AppInfoView : public views::DialogDelegateView,
+                    public base::SupportsWeakPtr<AppInfoView> {
  public:
   AppInfoView(Profile* profile,
               const extensions::Extension* app,
@@ -42,16 +45,24 @@ class AppInfoView : public views::DialogDelegateView {
   virtual ui::ModalType GetModalType() const OVERRIDE;
   virtual base::string16 GetWindowTitle() const OVERRIDE;
 
+  // Called when the app's ShortcutInfo (with icon) is loaded.
+  void OnAppImageLoaded(const gfx::Image& image);

[Matt Giuca, 2014/02/12 06:22:34]

The comment is out of date.

[sashab, 2014/02/17 07:20:56]

Done.

+
   // Profile in which the shortcuts will be created.
   Profile* profile_;
 
   // UI elements on the dialog.
   views::Label* app_name_label;
   views::Label* app_description_label;
+  views::Label* app_version_label;
+  views::ImageView* app_icon;
+  views::Label* permission_list_heading;
 
   const extensions::Extension* app_;
   base::Closure close_callback_;
 
+  base::WeakPtrFactory<AppInfoView> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(AppInfoView);
 };