Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1465803002: Remove ScopedVector from chunked_upload_data_stream (Closed)

Created:
5 years, 1 month ago by Olli Raula
Modified:
5 years, 1 month ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from chunked_upload_data_stream BUG=554289 Committed: https://crrev.com/882f4f9fe573c4c8a0ebd78a64dd4b9928370352 Cr-Commit-Position: refs/heads/master@{#361079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M net/base/chunked_upload_data_stream.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/base/chunked_upload_data_stream.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Olli Raula
PTAL
5 years, 1 month ago (2015-11-20 13:03:14 UTC) #3
eroman
lgtm
5 years, 1 month ago (2015-11-20 20:29:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465803002/1
5 years, 1 month ago (2015-11-23 07:15:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/144459)
5 years, 1 month ago (2015-11-23 08:31:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465803002/1
5 years, 1 month ago (2015-11-23 08:36:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 09:07:04 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 09:08:04 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/882f4f9fe573c4c8a0ebd78a64dd4b9928370352
Cr-Commit-Position: refs/heads/master@{#361079}

Powered by Google App Engine
This is Rietveld 408576698