Issue 14658005: filemanager: Retrieve 'shared-with-me' property using getDriveEntryProperties API.

Issue 14658005: filemanager: Retrieve 'shared-with-me' property using getDriveEntryProperties API. (Closed)

Created:
7 years, 7 months ago by Haruki Sato

Modified:
7 years, 7 months ago

Reviewers:
satorux1, not at google - send to devlin

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

filemanager: Retrieve 'shared-with-me' property using getDriveEntryProperties API. This CL renames getDriveFileProperties to getDriveEntryProperties and add "sharedWithMe" property in the result type. BUG=232992 TEST=No UI change. unittests. R=kalman@chromium.org, satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197576

Patch Set 1 #

Patch Set 2 : fix a comment. #

Total comments: 4

Patch Set 3 : rebase #

Patch Set 4 : update comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -32 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc	View	1 2 3	7 chunks	+26 lines, -17 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata/metadata_cache.js	View		4 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/api/file_browser_private.json	View	1 2 3	4 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

satorux1

lgtm with nits https://codereview.chromium.org/14658005/diff/5001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc (right): https://codereview.chromium.org/14658005/diff/5001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc#newcode2368 chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc:2368: // The properties meaningful for directories ...

7 years, 7 months ago (2013-05-01 06:04:41 UTC) #2

Haruki Sato

https://codereview.chromium.org/14658005/diff/5001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc (right): https://codereview.chromium.org/14658005/diff/5001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc#newcode2368 chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc:2368: // The properties meaningful for directories are already filled. ...

7 years, 7 months ago (2013-05-01 06:26:31 UTC) #4

Haruki Sato

7 years, 7 months ago (2013-05-01 06:27:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r197576 (presubmit successful).

Expand Messages | Collapse Messages