Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1465723002: Make XFA public more closely match master. (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Make XFA public more closely match master. There will be significant differences, but these are the minor ones. I removed a comment that doesn't seem to add a lot of value. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/326a2a78aaf7e0146bfcd283da888c08e34143f8

Patch Set 1 #

Total comments: 1

Patch Set 2 : spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -104 lines) Patch
M public/fpdf_dataavail.h View 2 chunks +2 lines, -3 lines 0 comments Download
M public/fpdf_doc.h View 3 chunks +0 lines, -12 lines 0 comments Download
M public/fpdf_edit.h View 13 chunks +0 lines, -46 lines 0 comments Download
M public/fpdf_flatten.h View 1 chunk +1 line, -2 lines 0 comments Download
M public/fpdf_ppo.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/fpdf_progressive.h View 3 chunks +0 lines, -11 lines 0 comments Download
M public/fpdf_text.h View 1 chunk +0 lines, -3 lines 0 comments Download
M public/fpdf_transformpage.h View 6 chunks +1 line, -12 lines 0 comments Download
M public/fpdfview.h View 1 4 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei
5 years, 1 month ago (2015-11-20 00:43:45 UTC) #2
Lei Zhang
lgtm, except for one section where we want to merge the other way. https://codereview.chromium.org/1465723002/diff/1/public/fpdfview.h File ...
5 years, 1 month ago (2015-11-20 01:57:43 UTC) #3
Tom Sepez
On 2015/11/20 01:57:43, Lei Zhang wrote: > lgtm, except for one section where we want ...
5 years, 1 month ago (2015-11-20 18:36:52 UTC) #4
Tom Sepez
5 years, 1 month ago (2015-11-20 18:47:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
326a2a78aaf7e0146bfcd283da888c08e34143f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698