Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1465713002: Revert of DevTools: [SSP] adding new property should be more predictable (Closed)

Created:
5 years, 1 month ago by lushnikov
Modified:
5 years, 1 month ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: [SSP] adding new property should be more predictable (patchset #2 id:20001 of https://codereview.chromium.org/1433903002/ ) Reason for revert: This patch makes selecting properties in SSP tedious. Example: 1. try selecting all properties of some rule 2. left-click in the empty space of the rule does not always removes selection Original issue's description: > DevTools: [SSP] adding new property should be more predictable > > Whitelist selectable elements to avoid excessive text "selectability". > > BUG=554454 > R=pfeldman, dgozman > > Committed: https://crrev.com/491172b142d4b302674c4552eea14cecd0421dbc > Cr-Commit-Position: refs/heads/master@{#360494} TBR=dgozman@chromium.org,pfeldman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=554454 Committed: https://crrev.com/d4d928857ead303fd863e7f97a4f3f22f880dd07 Cr-Commit-Position: refs/heads/master@{#360698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lushnikov
Created Revert of DevTools: [SSP] adding new property should be more predictable
5 years, 1 month ago (2015-11-20 00:33:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465713002/1
5 years, 1 month ago (2015-11-20 00:36:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 00:40:34 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 00:50:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4d928857ead303fd863e7f97a4f3f22f880dd07
Cr-Commit-Position: refs/heads/master@{#360698}

Powered by Google App Engine
This is Rietveld 408576698