editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java - Issue 14657012: Report CTEC.AMBIGUOUS_EXPORT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

Issue 14657012: Report CTEC.AMBIGUOUS_EXPORT (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Move implementation to ErrorVerifier Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/scope/Namespace.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

index 5532cd276ca8f762f5b727c8f61b951270f69d37..7fae45d1f5b1c665cc7b7db91bd667b3f94cb435 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

@@ -462,7 +462,8 @@ public class ElementResolver extends SimpleASTVisitor<Void> {

// The element is null when the URI is invalid

// TODO(brianwilkerson) Figure out whether the element can ever be something other than an

// ExportElement

- resolveCombinators(((ExportElement) element).getExportedLibrary(), node.getCombinators());

+ ExportElement exportElement = (ExportElement) element;

Brian Wilkerson 2013/05/10 14:56:04 nit: perhaps we could just back out the changes to

scheglov 2013/05/10 15:14:45 Done.

+ resolveCombinators(exportElement.getExportedLibrary(), node.getCombinators());

}

return null;

}