Source/modules/websockets/WebSocket.cpp - Issue 14657008: Make websocket error messages look better at the devtools console.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/WebSocket.cpp

Issue 14657008: Make websocket error messages look better at the devtools console. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/websockets/MainThreadWebSocketChannel.cpp ('k') | Source/modules/websockets/WebSocketChannel.h » ('j') | Source/modules/websockets/WebSocketChannel.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/WebSocket.cpp

diff --git a/Source/modules/websockets/WebSocket.cpp b/Source/modules/websockets/WebSocket.cpp

index 77ad3f144c81cebe4ec97d4f75f2e0efd081bb84..bbc30a9a6970876a61e7031e7deff4405c4f39d4 100644

--- a/Source/modules/websockets/WebSocket.cpp

+++ b/Source/modules/websockets/WebSocket.cpp

@@ -43,6 +43,7 @@

#include "core/dom/ScriptExecutionContext.h"

#include "core/fileapi/Blob.h"

#include "core/inspector/ScriptCallStack.h"

+#include "core/page/ConsoleTypes.h"

#include "core/page/ContentSecurityPolicy.h"

#include "core/page/DOMWindow.h"

#include "core/page/Frame.h"

@@ -392,7 +393,7 @@ void WebSocket::closeInternal(int code, const String& reason, ExceptionCode& ec)

return;

if (m_state == CONNECTING) {

m_state = CLOSING;

- m_channel->fail("WebSocket is closed before the connection is established.");

+ m_channel->fail("WebSocket is closed before the connection is established.", WarningMessageLevel);

return;

}

m_state = CLOSING;