Source/WebKit/chromium/src/WebSocketImpl.cpp - Issue 14657008: Make websocket error messages look better at the devtools console.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebSocketImpl.cpp

Issue 14657008: Make websocket error messages look better at the devtools console. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/websocket/tests/hybi/workers/close-expected.txt ('k') | Source/modules/websockets/MainThreadWebSocketChannel.h » ('j') | Source/modules/websockets/WebSocketChannel.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebKit/chromium/src/WebSocketImpl.cpp

diff --git a/Source/WebKit/chromium/src/WebSocketImpl.cpp b/Source/WebKit/chromium/src/WebSocketImpl.cpp

index 1c318117a7468167ac98bbcb997561badc20dee1..5c118282065fec5be8921aef9d1ff79a4d1436de 100644

--- a/Source/WebKit/chromium/src/WebSocketImpl.cpp

+++ b/Source/WebKit/chromium/src/WebSocketImpl.cpp

@@ -31,11 +31,12 @@

#include "config.h"

#include "WebSocketImpl.h"

+#include "RuntimeEnabledFeatures.h"

#include "WebArrayBuffer.h"

#include "WebDocument.h"

#include "WebSocketClient.h"

#include "core/dom/Document.h"

-#include "RuntimeEnabledFeatures.h"

+#include "core/page/ConsoleTypes.h"

#include "core/platform/KURL.h"

#include "modules/websockets/MainThreadWebSocketChannel.h"

#include "modules/websockets/WebSocketChannel.h"

@@ -115,7 +116,7 @@ void WebSocketImpl::close(int code, const WebString& reason)

void WebSocketImpl::fail(const WebString& reason)

{

- m_private->fail(reason);

+ m_private->fail(reason, ErrorMessageLevel);

}

void WebSocketImpl::disconnect()