Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1465633002: [heap] pause/resume inline allocation observers around scavenge (Closed)

Created:
5 years, 1 month ago by ofrobots
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] pause/resume inline allocation observers around scavenge We should not be counting the bump pointer allocations done during scavenge as the objects are copied. The inline allocation observers were getting unnecessary notifications. R=hpayer@chromium.org, ulan@chromium.org BUG= Committed: https://crrev.com/cd81dd6d740ff82a1abbc68615e8769bd467f91e Cr-Commit-Position: refs/heads/master@{#32153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -8 lines) Patch
M src/heap/heap.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +7 lines, -3 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +19 lines, -1 line 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ofrobots
5 years, 1 month ago (2015-11-19 21:41:16 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 1 month ago (2015-11-20 15:05:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465633002/1
5 years, 1 month ago (2015-11-20 16:02:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 16:20:02 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 16:20:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd81dd6d740ff82a1abbc68615e8769bd467f91e
Cr-Commit-Position: refs/heads/master@{#32153}

Powered by Google App Engine
This is Rietveld 408576698