Add detection of new or removed files to reproduce.sh

Add detection of new or removed files to reproduce.sh

R=dschuyler@chromium.org
BUG=none
NOTRY=true

Committed: https://crrev.com/a5278900efd26f3f55211ad74ce13f4c74d3c3aa
Cr-Commit-Position: refs/heads/master@{#360993}

[Dan Beam, 2015-11-21 02:34:46]

These files appear to have been added:
 
third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-shared-styles.html
 
third_party/polymer/v1_0/components-chromium/paper-item/paper-item-behavior-extracted.js
 
third_party/polymer/v1_0/components-chromium/paper-item/paper-item-behavior.html
 
third_party/polymer/v1_0/components-chromium/paper-menu/paper-menu-shared-styles.html

These files appear to have been removed:
  third_party/polymer/v1_0/components-chromium/paper-menu/paper-menu-shared.css

[Dan Beam, 2015-11-21 02:35:45]

better example: http://bit.ly/1N1A6Fv

[Dan Beam, 2015-11-21 02:39:16]

Description was changed from

==========
Add detection of new or removed files to reproduce.sh

R=dschuyler@chromium.org
BUG=none
==========

to

==========
Add detection of new or removed files to reproduce.sh

R=dschuyler@chromium.org
BUG=none
NOTRY=true
==========

[dschuyler, 2015-11-21 02:48:49]

lgtm

https://codereview.chromium.org/1465623008/diff/1/third_party/polymer/v1_0/re...
File third_party/polymer/v1_0/reproduce.sh (right):

https://codereview.chromium.org/1465623008/diff/1/third_party/polymer/v1_0/re...
third_party/polymer/v1_0/reproduce.sh:71: if [[ ! -z "${new}" ]]; then
nit: I'd have a preference for the build-in test '[' and testing for non-zero: 
e.g.
if [ -n "${new}" ]; then
(same nit for if's below).

https://codereview.chromium.org/1465623008/diff/20001/third_party/polymer/v1_...
File third_party/polymer/v1_0/reproduce.sh (right):

https://codereview.chromium.org/1465623008/diff/20001/third_party/polymer/v1_...
third_party/polymer/v1_0/reproduce.sh:67: 
nit: A comment like "The following informs the user whether files were added or
deleted".  I was looking at it to see what action it performed.  Saying that
it's fyi printouts would be a good comment.

[Dan Beam, 2015-11-21 02:56:26]

https://codereview.chromium.org/1465623008/diff/1/third_party/polymer/v1_0/re...
File third_party/polymer/v1_0/reproduce.sh (right):

https://codereview.chromium.org/1465623008/diff/1/third_party/polymer/v1_0/re...
third_party/polymer/v1_0/reproduce.sh:71: if [[ ! -z "${new}" ]]; then
On 2015/11/21 02:48:48, dschuyler wrote:
> nit: I'd have a preference for the build-in test '[' and testing for non-zero:

> e.g.
> if [ -n "${new}" ]; then
> (same nit for if's below).

https://google.github.io/styleguide/shell.xml?showone=Test,_%5B_and_%5B%5B#Te...

https://codereview.chromium.org/1465623008/diff/20001/third_party/polymer/v1_...
File third_party/polymer/v1_0/reproduce.sh (right):

https://codereview.chromium.org/1465623008/diff/20001/third_party/polymer/v1_...
third_party/polymer/v1_0/reproduce.sh:67: 
On 2015/11/21 02:48:49, dschuyler wrote:
> nit: A comment like "The following informs the user whether files were added
or
> deleted".  I was looking at it to see what action it performed.  Saying that
> it's fyi printouts would be a good comment.

that's pretty apparent from ... the code itself

[Dan Beam, 2015-11-21 02:56:28]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-11-21 02:57:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1465623008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1465623008/20001

[commit-bot: I haz the power, 2015-11-21 03:04:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-21 03:05:06]

Patchset 2 (id:??) landed as
https://crrev.com/a5278900efd26f3f55211ad74ce13f4c74d3c3aa
Cr-Commit-Position: refs/heads/master@{#360993}